Attention is currently required from: Jérémy Compostella.
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79739?usp=email )
Change subject: smm_module_handler.c: Align data to pointer size ......................................................................
smm_module_handler.c: Align data to pointer size
Align to pointer size rather than an arbitrary '4'.
Signed-off-by: Arthur Heymans arthur@aheymans.xyz Change-Id: Ibdfaf982c70b71191ac476616d769f2228b995b8 --- M src/cpu/x86/smm/smm_module_handler.c 1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/79739/1
diff --git a/src/cpu/x86/smm/smm_module_handler.c b/src/cpu/x86/smm/smm_module_handler.c index b16fa81..ba60548 100644 --- a/src/cpu/x86/smm/smm_module_handler.c +++ b/src/cpu/x86/smm/smm_module_handler.c @@ -7,6 +7,7 @@ #include <console/console.h> #include <cpu/cpu.h> #include <cpu/x86/smm.h> +#include <memlayout.h> #include <rmodule.h> #include <types.h> #include <security/intel/stm/SmmStm.h> @@ -21,10 +22,10 @@
/* SMI multiprocessing semaphore */ static volatile -__attribute__((aligned(4))) smi_semaphore smi_handler_status = SMI_UNLOCKED; +__attribute__((aligned(ARCH_POINTER_ALIGN_SIZE))) smi_semaphore smi_handler_status = SMI_UNLOCKED;
static const volatile -__attribute((aligned(4), __section__(".module_parameters"))) struct smm_runtime smm_runtime; +__attribute((aligned(ARCH_POINTER_ALIGN_SIZE), __section__(".module_parameters"))) struct smm_runtime smm_runtime;
static int smi_obtain_lock(void) {