[XS] Change in coreboot[master]: drivers/aspeed/common/ast_drv.h: Use C99 flexible arrays - coreboot-gerrit

3 Sep 2023


      Attention is currently required from: Martin L Roth, Maximilian Brune.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76844?usp=email )
Change subject: drivers/aspeed/common/ast_drv.h: Use C99 flexible arrays
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/aspeed/common/ast_drv.h:
https://review.coreboot.org/c/coreboot/+/76844/comment/7dafeb8d_9a3d2e2a :
PS2, Line 251: struct drm_format {
             : 	u32 cpp[]; /* Colors per pixel */
             : };
             :
...
Can't we just replace […]
defined as "u8 cpp[DRM_FORMAT_MAX_PLANES]" here https://github.com/torvalds/linux/blob/master/include/drm/drm_fourcc.h
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/76844?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I489347532e00581accaabad9ea4a3e0ad22f78f2
Gerrit-Change-Number: 76844
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-CC: Maximilian Brune maximilian.brune@9elements.com
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Comment-Date: Sun, 03 Sep 2023 14:24:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth gaumless@gmail.com
Comment-In-Reply-To: Maximilian Brune maximilian.brune@9elements.com
Gerrit-MessageType: comment