Change in coreboot[master]: mb/google/hatch/variants/helios: Update DPTF parameters and TDP PL1/PL2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34743 )
Change subject: mb/google/hatch/variants/helios: Update DPTF parameters and TDP PL1/PL2 ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34743/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/34743/2/src/mainboard/google/hatch/... PS2, Line 26: #define DPTF_TSR0_PASSIVE 0 : #define DPTF_TSR0_CRITICAL 0
Are they correct?
Done
https://review.coreboot.org/c/coreboot/+/34743/2/src/mainboard/google/hatch/... PS2, Line 31: #define DPTF_TSR1_PASSIVE 45 : #define DPTF_TSR1_CRITICAL 0
Are they correct?
Done
https://review.coreboot.org/c/coreboot/+/34743/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/helios/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/34743/1/src/mainboard/google/hatch/... PS1, Line 2: 8
ok,PL1 change to 13w, thanks
Done
-
Furquan Shaikh (Code Review)