Attention is currently required from: Furquan Shaikh, Sridhar Siricilla, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54733 )
Change subject: mb/google/volteer:intel/common/block: Move mainboard api to tcss common block
......................................................................
Patch Set 3:
(2 comments)
File src/drivers/intel/pmc_mux/conn/conn.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120417):
https://review.coreboot.org/c/coreboot/+/54733/comment/78c008be_cfad812c
PS3, Line 89: bool intel_pmc_mux_conn_get_ports(const struct device *conn, unsigned int *usb2_port,
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120417):
https://review.coreboot.org/c/coreboot/+/54733/comment/49bb62ea_34aef153
PS3, Line 93: if(!conn->chip_info || conn->chip_ops != &drivers_intel_pmc_mux_conn_ops)
space required before the open parenthesis '('
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54733
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7894363df4862f7cfe733d93e6160677fb8a9e31
Gerrit-Change-Number: 54733
Gerrit-PatchSet: 3
Gerrit-Owner: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 31 May 2021 17:30:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment