Attention is currently required from: Nico Huber, Martin Roth, Arthur Heymans, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52489 )
Change subject: sb/intel/lynxpoint: Add SerialIO UART console support
......................................................................
Patch Set 1:
(1 comment)
File src/southbridge/intel/lynxpoint/uart_init.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117163):
https://review.coreboot.org/c/coreboot/+/52489/comment/17d5671d_3e5d5c13
PS1, Line 16: switch (CONFIG_UART_FOR_CONSOLE) {
switch and case should be at the same indent
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52489
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb3460dd50ed03421a38f03c80f91ae9fd604022
Gerrit-Change-Number: 52489
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 18 Apr 2021 23:14:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment