Attention is currently required from: Anil Kumar K, Ashish Kumar Mishra, Cliff Huang, Felix Held, Jérémy Compostella, Paul Menzel, Saurabh Mishra.
Subrata Banik has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83419?usp=email )
Change subject: mb/google/fatcat: Add Panther Lake SOC support ......................................................................
Patch Set 199: Code-Review-1
(3 comments)
File src/mainboard/google/fatcat/Kconfig:
https://review.coreboot.org/c/coreboot/+/83419/comment/5c1baf97_6ba57e47?usp... : PS199, Line 20: PMC_IPC_ACPI_INTERFACE why are we dropping this now ?
https://review.coreboot.org/c/coreboot/+/83419/comment/d9e2da3e_d586d7bd?usp... : PS199, Line 23: SOC_INTEL_CSE_PRE_CPU_RESET_TELEMETRY_V2 why are we dropping this now ?
https://review.coreboot.org/c/coreboot/+/83419/comment/16ef87d8_4ee2e885?usp... : PS199, Line 106: config OVERRIDE_DEVICETREE : default "variants/$(CONFIG_VARIANT_DIR)/overridetree.cb" why are we dropping this now ?
resulted in compilation error
``` In file included from src/mainboard/google/fatcat/variants/fatcat/variant.c:5: src/mainboard/google/fatcat/variants/fatcat/variant.c: In function 'get_wifi_sar_cbfs_filename': src/include/fw_config.h:41:23: error: 'FW_CONFIG_FIELD_WIFI_NAME' undeclared (first use in this function) 41 | .field_name = FW_CONFIG_FIELD_##__field##_NAME, \ | ^~~~~~~~~~~~~~~~ src/mainboard/google/fatcat/variants/fatcat/variant.c:10:48: note: in expansion of macro 'FW_CONFIG_FIELD' 10 | return get_wifi_sar_fw_config_filename(FW_CONFIG_FIELD(WIFI)); | ^~~~~~~~~~~~~~~ src/include/fw_config.h:41:23: note: each undeclared identifier is reported only once for each function it appears in 41 | .field_name = FW_CONFIG_FIELD_##__field##_NAME, \ | ^~~~~~~~~~~~~~~~ src/mainboard/google/fatcat/variants/fatcat/variant.c:10:48: note: in expansion of macro 'FW_CONFIG_FIELD' 10 | return get_wifi_sar_fw_config_filename(FW_CONFIG_FIELD(WIFI)); | ^~~~~~~~~~~~~~~ CC ramstage/lib/memchr.o src/include/fw_config.h:42:17: error: 'FW_CONFIG_FIELD_WIFI_MASK' undeclared (first use in this function) 42 | .mask = FW_CONFIG_FIELD_##__field##_MASK, \ | ^~~~~~~~~~~~~~~~ src/mainboard/google/fatcat/variants/fatcat/variant.c:10:48: note: in expansion of macro 'FW_CONFIG_FIELD' 10 | return get_wifi_sar_fw_config_filename(FW_CONFIG_FIELD(WIFI)); | ^~~~~~~~~~~~~~~ src/mainboard/google/fatcat/variants/fatcat/variant.c:11:1: error: control reaches end of non-void function [-Werror=return-type] 11 | }
```