[M] Change in coreboot[master]: Add basic support for Raptor Lake S CPUs on Alder Lake PCH (#640555 R...
Attention is currently required from: Bora Guvendik, Subrata Banik, Name of user not set #1004406, Michal Zygowski.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69798 )
Change subject: Add basic support for Raptor Lake S CPUs on Alder Lake PCH (#640555 Rev. 2.2) ......................................................................
Patch Set 4:
(8 comments)
File src/include/cpu/intel/cpu_ids.h:
https://review.coreboot.org/c/coreboot/+/69798/comment/74e390c8_611d09f6 PS3, Line 67: #define CPUID_RAPTORLAKE_S_S0 0xb0671
CPUID_RAPTORLAKE_S_B0 it is B0 stepping according to the datasheet. And if so, I would also add: […]
Ack
File src/soc/intel/alderlake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/69798/comment/f8562f72_31e026ac PS3, Line 37: { CPUID_RAPTORLAKE_S_S0, "Raptorlake-S S0 Platform" },
{ CPUID_RAPTORLAKE_S_B0, "Raptorlake-S B0 Platform" },
Ack
https://review.coreboot.org/c/coreboot/+/69798/comment/75ca1d29_f01e2575 PS3, Line 207: { PCI_DID_INTEL_RPL_S_GT1, "Raptorlake S GT1(32EU)" }, : { PCI_DID_INTEL_RPL_S_GT2, "Raptorlake S GT2(24EU)" }, : { PCI_DID_INTEL_RPL_S_GT3, "Raptorlake S GT3(16EU)" },
Let's stick with previous convention and omit execution units.
Ack
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/69798/comment/4cfd96d1_0c7635cd PS3, Line 544: return ICC_MAX_ADL_S;
Isn't it 36A for RPL-S?
Ack
File src/soc/intel/alderlake/include/soc/cpu.h:
https://review.coreboot.org/c/coreboot/+/69798/comment/cf4d391a_0fb41070 PS3, Line 28: RPL_S,
Please add it as a last item in the enum
Ack
File src/soc/intel/alderlake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/69798/comment/bb2ce447_8d9c3dd3 PS3, Line 174: { PCI_DID_INTEL_RPL_S_ID_1, 125, VR_CFG_ALL_DOMAINS_ICC(280, 30) }, : { PCI_DID_INTEL_RPL_S_ID_2, 125, VR_CFG_ALL_DOMAINS_ICC(280, 30) },
RPL-S 8+16 and 8+8 have 307A ICCmax for IA domain.
Ack
https://review.coreboot.org/c/coreboot/+/69798/comment/36313269_16e8eb8a PS3, Line 176: { PCI_DID_INTEL_RPL_S_ID_3, 125, VR_CFG_ALL_DOMAINS_ICC(280, 30) },
RPL-S 6+8 has 200A ICCmax for IA domain
Ack
File src/soc/intel/common/block/cpu/mp_init.c:
https://review.coreboot.org/c/coreboot/+/69798/comment/2ff1ce4a_577ba1a2 PS3, Line 84: { X86_VENDOR_INTEL, CPUID_RAPTORLAKE_S_S0 },
{ X86_VENDOR_INTEL, CPUID_RAPTORLAKE_S_B0 },
Ack
-
Michał Żygowski (Code Review)