build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41728 )
Change subject: drivers/intel/fsp2_0: Add FSP 2.2 specific support ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41728/7/src/drivers/intel/fsp2_0/si... File src/drivers/intel/fsp2_0/silicon_init.c:
https://review.coreboot.org/c/coreboot/+/41728/7/src/drivers/intel/fsp2_0/si... PS7, Line 28: return 1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/41728/7/src/drivers/intel/fsp2_0/si... PS7, Line 28: return 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/41728/7/src/drivers/intel/fsp2_0/si... PS7, Line 87: FSPS_ARCH_UPD *arch_upd; need consistent spacing around '*' (ctx:WxV)