Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85250?usp=email )
Change subject: mb/google/rauru: Add configuration for SD card detect pin
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/rauru/chromeos.c:
https://review.coreboot.org/c/coreboot/+/85250/comment/7ae5e23b_1f0590ca?usp... :
PS1, Line 34: struct lb_gpio sd_card_gpios[] = {
: { GPIO_SD_CD_AP_ODL.id, ACTIVE_LOW, -1, "SD card detect" },
: };
: lb_add_gpios(gpios, sd_card_gpios, ARRAY_SIZE(sd_card_gpios));
Navi does not support SD card. So we should not pass this pin to payload. Please refer to corsola and refine the logic.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85250?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1901fd45833f2415c61b61f9e04ebb54440df80a
Gerrit-Change-Number: 85250
Gerrit-PatchSet: 1
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Yidi Lin
yidilin@google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 22 Nov 2024 14:34:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No