Change in coreboot[master]: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad
Johnny Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42921 ) Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ...................................................................... mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz. BUG=b:157999726 TEST= Verified that I2C5 frequency is between 389-396kHz. Change-Id: I4518326a7a60dafb7d42a395b913a01e1e8a1f70 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 113 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/42921/1 diff --git a/src/mainboard/google/volteer/variants/volteer/overridetree.cb b/src/mainboard/google/volteer/variants/volteer/overridetree.cb index 9e5ef4b..bd5f1fe 100644 --- a/src/mainboard/google/volteer/variants/volteer/overridetree.cb +++ b/src/mainboard/google/volteer/variants/volteer/overridetree.cb @@ -37,6 +37,79 @@ end end end + device pci 15.1 on + chip drivers/i2c/hid + register "generic.hid" = ""GDIX0000"" + register "generic.desc" = ""Goodix Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_E7_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C10)" + register "generic.reset_delay_ms" = "120" + register "generic.reset_off_delay_ms" = "3" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A8)" + register "generic.enable_delay_ms" = "12" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 14 on end + end + chip drivers/i2c/hid + register "generic.hid" = ""ELAN90FC"" + register "generic.desc" = ""ELAN Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_E7_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C10)" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A8)" + register "generic.reset_delay_ms" = "20" + register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 10 on end + end + end # I2C1 0xA0E9 + device pci 15.2 on + chip drivers/i2c/sx9310 + register "desc" = ""SAR0 Proximity Sensor"" + register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_F14_IRQ)" + register "speed" = "I2C_SPEED_FAST" + register "uid" = "0" + register "reg_prox_ctrl0" = "0x10" + register "reg_prox_ctrl1" = "0x00" + register "reg_prox_ctrl2" = "0x84" + register "reg_prox_ctrl3" = "0x0e" + register "reg_prox_ctrl4" = "0x07" + register "reg_prox_ctrl5" = "0xc6" + register "reg_prox_ctrl6" = "0x20" + register "reg_prox_ctrl7" = "0x0d" + register "reg_prox_ctrl8" = "0x8d" + register "reg_prox_ctrl9" = "0x43" + register "reg_prox_ctrl10" = "0x1f" + register "reg_prox_ctrl11" = "0x00" + register "reg_prox_ctrl12" = "0x00" + register "reg_prox_ctrl13" = "0x00" + register "reg_prox_ctrl14" = "0x00" + register "reg_prox_ctrl15" = "0x00" + register "reg_prox_ctrl16" = "0x00" + register "reg_prox_ctrl17" = "0x00" + register "reg_prox_ctrl18" = "0x00" + register "reg_prox_ctrl19" = "0x00" + register "reg_sar_ctrl0" = "0x50" + register "reg_sar_ctrl1" = "0x8a" + register "reg_sar_ctrl2" = "0x3c" + device i2c 28 on end + end + end # I2C2 0xA0EA + device pci 19.1 on + chip drivers/i2c/generic + register "hid" = ""ELAN0000"" + register "desc" = ""ELAN Touchpad"" + register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_E15_IRQ)" + register "wake" = "GPE0_DW2_15" + register "probed" = "1" + device i2c 15 on end + end + end # I2C5 0xA0C6 device pci 1f.3 on chip drivers/generic/max98357a register "hid" = ""MX98357A"" @@ -88,5 +161,45 @@ end end end # PMC + # Intel Common SoC Config + #+-------------------+---------------------------+ + #| Field | Value | + #+-------------------+---------------------------+ + #| chipset_lockdown | CHIPSET_LOCKDOWN_COREBOOT | + #| GSPI0 | cr50 TPM. Early init is | + #| | required to set up a BAR | + #| | for TPM communication | + #| | before memory is up | + #| GSPI1 | Fingerprint MCU | + #| I2C0 | Audio | + #| I2C1 | Touchscreen | + #| I2C2 | WLAN, SAR0 | + #| I2C3 | Camera, SAR1 | + #| I2C5 | Trackpad | + #+-------------------+---------------------------+ + register "common_soc_config" = "{ + .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT, + .gspi[0] = { + .speed_mhz = 1, + .early_init = 1, + }, + .i2c[0] = { + }, + .i2c[1] = { + }, + .i2c[2] = { + }, + .i2c[3] = { + }, + .i2c[5] = { + .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 163, + .scl_hcnt = 75, + .sda_hold = 36, + }, + }, + }" end end -- To view, visit https://review.coreboot.org/c/coreboot/+/42921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4518326a7a60dafb7d42a395b913a01e1e8a1f70 Gerrit-Change-Number: 42921 Gerrit-PatchSet: 1 Gerrit-Owner: Johnny Li <johnny_li@wistron.corp-partner.google.com> Gerrit-MessageType: newchange
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42921 ) Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ...................................................................... Patch Set 1: (3 comments) https://review.coreboot.org/c/coreboot/+/42921/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/volteer/overridetree.cb: https://review.coreboot.org/c/coreboot/+/42921/1/src/mainboard/google/voltee... PS1, Line 188: .i2c[1] = { trailing whitespace https://review.coreboot.org/c/coreboot/+/42921/1/src/mainboard/google/voltee... PS1, Line 190: .i2c[2] = { trailing whitespace https://review.coreboot.org/c/coreboot/+/42921/1/src/mainboard/google/voltee... PS1, Line 192: .i2c[3] = { trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/42921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4518326a7a60dafb7d42a395b913a01e1e8a1f70 Gerrit-Change-Number: 42921 Gerrit-PatchSet: 1 Gerrit-Owner: Johnny Li <johnny_li@wistron.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Tue, 30 Jun 2020 12:33:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/42921 to look at the new patch set (#2). Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ...................................................................... mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz. BUG=b:157999726 TEST= Verified that I2C5 frequency is between 389-396kHz. Change-Id: I4518326a7a60dafb7d42a395b913a01e1e8a1f70 Signed-off-by: Johnny Li <johnny_li@wistron.corp-partner.google.com> --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 113 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/42921/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/42921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4518326a7a60dafb7d42a395b913a01e1e8a1f70 Gerrit-Change-Number: 42921 Gerrit-PatchSet: 2 Gerrit-Owner: Johnny Li <johnny_li@wistron.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42921 ) Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ...................................................................... Patch Set 2: (3 comments) https://review.coreboot.org/c/coreboot/+/42921/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/volteer/overridetree.cb: https://review.coreboot.org/c/coreboot/+/42921/2/src/mainboard/google/voltee... PS2, Line 188: .i2c[1] = { trailing whitespace https://review.coreboot.org/c/coreboot/+/42921/2/src/mainboard/google/voltee... PS2, Line 190: .i2c[2] = { trailing whitespace https://review.coreboot.org/c/coreboot/+/42921/2/src/mainboard/google/voltee... PS2, Line 192: .i2c[3] = { trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/42921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4518326a7a60dafb7d42a395b913a01e1e8a1f70 Gerrit-Change-Number: 42921 Gerrit-PatchSet: 2 Gerrit-Owner: Johnny Li <johnny_li@wistron.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Tue, 30 Jun 2020 15:51:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/42921 to look at the new patch set (#3). Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ...................................................................... mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz. BUG=b:157999726 TEST= Verified that I2C5 frequency is between 389-396kHz. Change-Id: I4518326a7a60dafb7d42a395b913a01e1e8a1f70 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 113 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/42921/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/42921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4518326a7a60dafb7d42a395b913a01e1e8a1f70 Gerrit-Change-Number: 42921 Gerrit-PatchSet: 3 Gerrit-Owner: Johnny Li <johnny_li@wistron.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/42921 to look at the new patch set (#4). Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ...................................................................... mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz. BUG=b:157999726 TEST= Verified that I2C5 frequency is between 389-396kHz. Change-Id: I4518326a7a60dafb7d42a395b913a01e1e8a1f70 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 113 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/42921/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/42921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4518326a7a60dafb7d42a395b913a01e1e8a1f70 Gerrit-Change-Number: 42921 Gerrit-PatchSet: 4 Gerrit-Owner: Johnny Li <johnny_li@wistron.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/42921 to look at the new patch set (#5). Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ...................................................................... mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad This change updates scl_lcnt,scl_hcnt,scl_hcnt value for I2C5 to bring the bus frequency closer to 400kHz. BUG=b:157999726 TEST= Verified that I2C5 frequency is between 389-396kHz. Change-Id: I4518326a7a60dafb7d42a395b913a01e1e8a1f70 Signed-off-by:Johnny Li <johnny_li@wistron.corp-partner.google.com> --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 113 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/42921/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/42921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4518326a7a60dafb7d42a395b913a01e1e8a1f70 Gerrit-Change-Number: 42921 Gerrit-PatchSet: 5 Gerrit-Owner: Johnny Li <johnny_li@wistron.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Johnny Li has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42921 ) Change subject: mb/google/volteer/variants/volteer : Tune I2C5 params for Trackpad ...................................................................... Abandoned upload fail -- To view, visit https://review.coreboot.org/c/coreboot/+/42921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4518326a7a60dafb7d42a395b913a01e1e8a1f70 Gerrit-Change-Number: 42921 Gerrit-PatchSet: 5 Gerrit-Owner: Johnny Li <johnny_li@wistron.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: abandon
participants (2)
-
build bot (Jenkins) (Code Review) -
Johnny Li (Code Review)