Change in coreboot[master]: ChromeOS: Add DECLARE_x_CROS_GPIOS()
Attention is currently required from: Jason Glenesk, Marshall Dawson, Nick Vaccaro, Kyösti Mälkki, Fred Reitberger, Karthik Ramasubramanian. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58899 ) Change subject: ChromeOS: Add DECLARE_x_CROS_GPIOS() ...................................................................... Patch Set 17: (1 comment) Patchset: PS4:
I do not like the function part of this either, let me find another way. This is much better!
-- To view, visit https://review.coreboot.org/c/coreboot/+/58899 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88406fa1b54312616e6717af3d924436dc4ff1a6 Gerrit-Change-Number: 58899 Gerrit-PatchSet: 17 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred@gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro@chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk@gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd@gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro@chromium.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred@gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub@google.com> Gerrit-Comment-Date: Tue, 05 Apr 2022 14:35:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak@chromium.org> Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-MessageType: comment
participants (1)
-
Tim Wawrzynczak (Code Review)