Attention is currently required from: Hung-Te Lin.
Liju-Clr Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72839 )
Change subject: mb/google/geralt: Calling mt6359p_init() only once in ramstage ......................................................................
mb/google/geralt: Calling mt6359p_init() only once in ramstage
The regulator APIs are called by firmware display and SD card. Therefore, add mt6359p_init() in mainboard.c to initialize mt6359 only once in ramstage.
BUG=b:244208960 TEST=test firmware display pass for BOE_TV110C9M_LL0 on Geralt.
Change-Id: I29498d186ba5665ae20e84985174fc10f8d4accd Signed-off-by: Liju-Clr Chen liju-clr.chen@mediatek.com --- M src/mainboard/google/geralt/mainboard.c M src/soc/mediatek/mt8188/msdc.c 2 files changed, 20 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/72839/1
diff --git a/src/mainboard/google/geralt/mainboard.c b/src/mainboard/google/geralt/mainboard.c index ff893e0..c9eef65 100644 --- a/src/mainboard/google/geralt/mainboard.c +++ b/src/mainboard/google/geralt/mainboard.c @@ -4,6 +4,7 @@ #include <device/device.h> #include <soc/bl31.h> #include <soc/msdc.h> +#include <soc/mt6359p.h> #include <soc/usb.h>
#include "display.h" @@ -11,6 +12,8 @@
static void mainboard_init(struct device *dev) { + mt6359p_init(); + if (display_init_required()) { if (configure_display() < 0) printk(BIOS_ERR, "%s: Failed to init display\n", __func__); diff --git a/src/soc/mediatek/mt8188/msdc.c b/src/soc/mediatek/mt8188/msdc.c index 37a96a7..3dd629e 100644 --- a/src/soc/mediatek/mt8188/msdc.c +++ b/src/soc/mediatek/mt8188/msdc.c @@ -107,7 +107,6 @@ MSDC1_GPIO_MODE1_0, MSDC1_GPIO_MODE1_VALUE);
/* enable SD card power */ - mt6359p_init(); mainboard_enable_regulator(MTK_REGULATOR_VMCH, true); mainboard_enable_regulator(MTK_REGULATOR_VMC, true); mainboard_set_regulator_voltage(MTK_REGULATOR_VMCH, 3000000);