[M] Change in coreboot[main]: mb/google/brya/var/xol: Configure power limits by battery status

[Paul Menzel (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jamie Chen, Kapil Porwal, Nick Vaccaro, SH Kim, Subrata Banik, Sumeet R Pawnikar.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81614?usp=email )

Change subject: mb/google/brya/var/xol: Configure power limits by battery status
......................................................................


Patch Set 4:

(6 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/81614/comment/ac7b72ec_6762ea4b :
PS2, Line 18: MSR PL2: 55W, MSR PL4: 114W
> I mentioned I used PTAT.
> Sorry, I do not know what PTAT is.

Commit Message:

https://review.coreboot.org/c/coreboot/+/81614/comment/01c5bf53_725d32e7 :
PS4, Line 7: Configure power limits by battery status
Maybe:

Reduce power limits with critical bat level or no bat


https://review.coreboot.org/c/coreboot/+/81614/comment/9f49dd78_56804619 :
PS4, Line 18: veified
verified


https://review.coreboot.org/c/coreboot/+/81614/comment/cfdbe5ba_02c9402d :
PS4, Line 23: adaptor
adapt*e*r


https://review.coreboot.org/c/coreboot/+/81614/comment/31b218bf_d432b878 :
PS4, Line 29: adaptor
Ditto.


File src/mainboard/google/brya/variants/xol/ramstage.c:

https://review.coreboot.org/c/coreboot/+/81614/comment/09a8cfb1_18e45828 :
PS4, Line 27: 	printk(BIOS_INFO, "Cannot get PD power info\n");
Please also print the return value. Should this be a warning?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/81614?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5d71e9edde0ecbd7aaf316cd754a6ebcff9da77d
Gerrit-Change-Number: 81614
Gerrit-PatchSet: 4
Gerrit-Owner: SH Kim <[e-mail]>
Gerrit-Reviewer: Dinesh Gehlot <[e-mail]>
Gerrit-Reviewer: Eric Lai <[e-mail]>
Gerrit-Reviewer: Jamie Chen <[e-mail]>
Gerrit-Reviewer: Kapil Porwal <[e-mail]>
Gerrit-Reviewer: Nick Vaccaro <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: Sumeet R Pawnikar <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Attention: Eric Lai <[e-mail]>
Gerrit-Attention: Jamie Chen <[e-mail]>
Gerrit-Attention: Subrata Banik <[e-mail]>
Gerrit-Attention: SH Kim <[e-mail]>
Gerrit-Attention: Kapil Porwal <[e-mail]>
Gerrit-Attention: Dinesh Gehlot <[e-mail]>
Gerrit-Attention: Sumeet R Pawnikar <[e-mail]>
Gerrit-Attention: Nick Vaccaro <[e-mail]>
Gerrit-Comment-Date: Mon, 01 Apr 2024 08:00:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: SH Kim <[e-mail]>
Comment-In-Reply-To: Paul Menzel <[e-mail]>
Gerrit-MessageType: comment