Attention is currently required from: Jonathan Zhang, David Hendricks, Christian Walter, Arthur Heymans, Elyes Haouas, Tim Chu.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72441 )
Change subject: soc/intel/xeon_sp/chip_common.c: check SOC_INTEL_PCIE_64BIT_ALLOC
......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/xeon_sp/chip_common.c:
https://review.coreboot.org/c/coreboot/+/72441/comment/d63ee06c_03bfd127
PS6, Line 410: #if
why "#if"? […]
line 414 PlatformData.Pci64BitResourceAllocation may not be defined by platforms selecting SOC_INTEL_PCIE_64BIT_ALLOC, by using C will see build error:
src/soc/intel/xeon_sp/chip_common.c:414:33: error: 'PLATFORM_DATA' has no member named 'Pci64BitResourceAllocation'
414 | return hob->PlatformData.Pci64BitResourceAllocation;
So C preprocessor is needed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72441
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic33967255baf4675cd72e0db32ef3fb7f5658296
Gerrit-Change-Number: 72441
Gerrit-PatchSet: 6
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Tue, 07 Feb 2023 14:11:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment