Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67810 )
Change subject: mb/google/skyrim: Rename pcie_gpio_table to romstage_gpio_table
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/skyrim/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/67810/comment/e32906f0_400d36fa
PS2, Line 196: PAD_GPO(GPIO_7, HIGH),
We'll need to make sure the power-on timings for all of the WLAN devices are still met after this wa […]
nothing was moved, only the function renamed. The GPIOs are still set at exactly the same time as before.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67810
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I285602209072247895c2cb0830f3faf675328757
Gerrit-Change-Number: 67810
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-Comment-Date: Thu, 01 Dec 2022 16:51:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-MessageType: comment