Attention is currently required from: Shuming Chu (Shuming).
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70662 )
Change subject: include/memory_info.h: Add soc_num to dimm_info struct
......................................................................
Patch Set 2:
(1 comment)
File src/include/memory_info.h:
https://review.coreboot.org/c/coreboot/+/70662/comment/350afc20_afa53ebe
PS2, Line 51: dimm_num
I'm confused
isn't dimm_num = soc_num ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70662
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b9e2b87fda2d7c32ecb8ce9d989795c8b869cea
Gerrit-Change-Number: 70662
Gerrit-PatchSet: 2
Gerrit-Owner: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Comment-Date: Sun, 08 Jan 2023 06:38:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment