Keith Hui has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41461 )
Change subject: nb/intel/i440bx: Enable bootblock console ......................................................................
nb/intel/i440bx: Enable bootblock console
Change-Id: Ie59593d3e3e0c455ffd3813980d1c2fe801c3c18 Signed-off-by: Keith Hui buurin@gmail.com --- M src/northbridge/intel/i440bx/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/41461/1
diff --git a/src/northbridge/intel/i440bx/Kconfig b/src/northbridge/intel/i440bx/Kconfig index 8a6783e..d51cc0c 100644 --- a/src/northbridge/intel/i440bx/Kconfig +++ b/src/northbridge/intel/i440bx/Kconfig @@ -4,7 +4,6 @@ bool select NO_MMCONF_SUPPORT select HAVE_DEBUG_RAM_SETUP - select NO_BOOTBLOCK_CONSOLE
config SDRAMPWR_4DIMM bool
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41461 )
Change subject: nb/intel/i440bx: Enable bootblock console ......................................................................
Patch Set 2: Code-Review+2
Hello build bot (Jenkins), Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41461
to look at the new patch set (#4).
Change subject: nb/intel/i440bx: Enable bootblock console ......................................................................
nb/intel/i440bx: Enable bootblock console
Change-Id: Ie59593d3e3e0c455ffd3813980d1c2fe801c3c18 Signed-off-by: Keith Hui buurin@gmail.com --- M src/northbridge/intel/i440bx/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/41461/4
Attention is currently required from: Keith Hui. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41461 )
Change subject: nb/intel/i440bx: Enable bootblock console ......................................................................
Patch Set 7: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41461 )
Change subject: nb/intel/i440bx: Enable bootblock console ......................................................................
nb/intel/i440bx: Enable bootblock console
Change-Id: Ie59593d3e3e0c455ffd3813980d1c2fe801c3c18 Signed-off-by: Keith Hui buurin@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41461 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/i440bx/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/northbridge/intel/i440bx/Kconfig b/src/northbridge/intel/i440bx/Kconfig index 0e61285..ff8e2ae 100644 --- a/src/northbridge/intel/i440bx/Kconfig +++ b/src/northbridge/intel/i440bx/Kconfig @@ -4,7 +4,6 @@ bool select NO_MMCONF_SUPPORT select HAVE_DEBUG_RAM_SETUP - select NO_BOOTBLOCK_CONSOLE select NO_CBFS_MCACHE
config SDRAMPWR_4DIMM
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Keith Hui (Code Review)
-
Patrick Georgi (Code Review)