Attention is currently required from: Dinesh Gehlot, Erik van den Bogaert, Frans Hendriks, Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik.
Harrie Paijmans has posted comments on this change by Harrie Paijmans. ( https://review.coreboot.org/c/coreboot/+/87243?usp=email )
Change subject: device/pci_ids: Add Amston Lake CPU IDs
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/87243/comment/86af3115_dd9f869e?usp... :
PS2, Line 7: Amstonlake
Amston Lake
done
https://review.coreboot.org/c/coreboot/+/87243/comment/9f5a95ff_b9914a85?usp... :
PS2, Line 13: Alderlake
Alder Lake
done
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/87243/comment/6dfa3d4a_9b1a9683?usp... :
PS2, Line 4430: #define PCI_DID_INTEL_ASL_ID_1 0x4675
: #define PCI_DID_INTEL_ASL_ID_2 0x4674
: #define PCI_DID_INTEL_ASL_ID_3 0x4632
Is the mapping 1 to 0x4675 from the datasheet, or could the smaller number 0x4632 be 1?
The mapping was done in the order of the datasheet.
I changed the order to be inline with the other ID's in the source.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87243?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia43945887e7d536b5b7387a4dda4e245973c27ee
Gerrit-Change-Number: 87243
Gerrit-PatchSet: 3
Gerrit-Owner: Harrie Paijmans
hpaijmans@eltan.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Frans Hendriks
fhendriks@eltan.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 11 Apr 2025 08:44:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org