[S] Change in coreboot[main]: drivers/intel/gma: Update port select bit definitions
Attention is currently required from: Arthur Heymans, Julius Werner, Kapil Porwal, Karthik Ramasubramanian, Lean Sheng Tan, Nick Vaccaro, Nick Vaccaro, Werner Zeh. Hello Arthur Heymans, Julius Werner, Kapil Porwal, Lean Sheng Tan, Nick Vaccaro, Nick Vaccaro, Werner Zeh, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78078?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: drivers/intel/gma: Update port select bit definitions ...................................................................... drivers/intel/gma: Update port select bit definitions This commit updates the port select bit definitions for the TRANS_DDI_FUNC_CTL registers in the Intel GMA driver to accommodate the changes introduced since TGL SoC. Specifically, the following changes were made: - Updated the DDI select bit definitions from 3-bits (bit 28-30) to 4-bits (bit 27-30). - Introduces `INTEL_GMA_VERSION_2` config to accommodate the port and pipe related differences between previous generation GMA register (TRANS_DDI_FUNC_CTL) to the current generation GMA register. This commit backports the change from the following upstream patch: https://patchwork.freedesktop.org/patch/msgid/20190713010940.17711-3- lucas.demarchi@intel.com BUG=b:299137940 TEST=Able to build and boot google/rex. Change-Id: I815ffa90c2e235afd70baa7e3837e1f9af89b1b0 Signed-off-by: Subrata Banik <subratabanik@google.com> --- M src/drivers/intel/gma/Kconfig M src/drivers/intel/gma/i915.h M src/drivers/intel/gma/i915_reg.h 3 files changed, 36 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/78078/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78078?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I815ffa90c2e235afd70baa7e3837e1f9af89b1b0 Gerrit-Change-Number: 78078 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik@google.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan@9elements.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro@chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro@google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Karthik Ramasubramanian <kramasub@google.com> Gerrit-Attention: Kapil Porwal <kapilporwal@google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro@chromium.org> Gerrit-Attention: Julius Werner <jwerner@chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro@google.com> Gerrit-Attention: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan@9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh@siemens.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub@google.com> Gerrit-MessageType: newpatchset
participants (1)
-
Subrata Banik (Code Review)