Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41967 )
Change subject: acpi: Drop typoed __ROMC__ ......................................................................
acpi: Drop typoed __ROMC__
Change-Id: I4fcec5bbc038a31565882631052ab07e38946e65 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/include/acpi/acpi.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/41967/1
diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index ea80e3b..2b001ac 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -1046,6 +1046,6 @@ * coreboot default ACPI spec version supported. */ int get_acpi_table_revision(enum acpi_tables table);
-#endif // !defined(__ASSEMBLER__) && !defined(__ACPI__) && !defined(__ROMC__) +#endif // !defined(__ASSEMBLER__) && !defined(__ACPI__)
#endif /* __ACPI_ACPI_H__ */
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41967 )
Change subject: acpi: Drop typoed __ROMC__ ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41967 )
Change subject: acpi: Drop typoed __ROMC__ ......................................................................
acpi: Drop typoed __ROMC__
Change-Id: I4fcec5bbc038a31565882631052ab07e38946e65 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41967 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/include/acpi/acpi.h 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index 34cb6ea..ba056c0 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -1054,6 +1054,6 @@ * coreboot default ACPI spec version supported. */ int get_acpi_table_revision(enum acpi_tables table);
-#endif // !defined(__ASSEMBLER__) && !defined(__ACPI__) && !defined(__ROMC__) +#endif // !defined(__ASSEMBLER__) && !defined(__ACPI__)
#endif /* __ACPI_ACPI_H__ */
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41967 )
Change subject: acpi: Drop typoed __ROMC__ ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4759 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4758 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4757 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4756
Please note: This test is under development and might not be accurate at all!