Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Kapil Porwal, Subrata Banik, Sukumar Ghorai, Tarun.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79386?usp=email )
Change subject: mb/google/{rex,ovis}: epp set to 45% for mtl performance expectation ......................................................................
Patch Set 3:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79386/comment/2b429b5b_d96c5573 : PS3, Line 7: epp set to 45% for mtl performance expectation Maybe:
Decrease EPP to 45 % for MTL performance expectation
https://review.coreboot.org/c/coreboot/+/79386/comment/e51023fb_a398e364 : PS3, Line 9: which is deemed insufficiently : aggressive for meeting the MTL performance expectations in : balance_performance mode. According to whom? Also, what does that mean exactly? It’s drawing too much power?
https://review.coreboot.org/c/coreboot/+/79386/comment/46909162_acee6072 : PS3, Line 12: #cat Please add a space after #.
https://review.coreboot.org/c/coreboot/+/79386/comment/18ffa3d2_a755e492 : PS3, Line 11: balance_performance mode. : #cat /sys/devices/system/cpu/cpu0/cpufreq/energy_performance_preference : balance_performance : # iotools rdmsr 0 0x774 : 0x0000000080003f06 : EPP=45% is giving the required performance in MTL. I’d follow Markdown and intend code blocks with four spaces. (And also add blank lines around the block.)
https://review.coreboot.org/c/coreboot/+/79386/comment/f3d5ff83_f9f51e09 : PS3, Line 20: # iotools rdmsr 0 0x774 : 0x0000000073003d06 How can the value be interpreted?