Attention is currently required from: Raul Rangel, Furquan Shaikh, Karthik Ramasubramanian.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56576 )
Change subject: lib/cbfs: Call rdev_unmap on hash mismatch
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56576/comment/bb523a3e_39c8bd81
PS2, Line 9: I also print an error if the mmap
: failed.
Commits should do just one thing. This shouldn't be part of this commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56576
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibcd28ce12cbd5e221e8f4fa910fd8472bedb802f
Gerrit-Change-Number: 56576
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Sun, 05 Sep 2021 15:17:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment