Attention is currently required from: Utkarsh H Patel, Subrata Banik, Kapil Porwal, Ivy Jian, Sridhar Siricilla, Eric Lai.
Sukumar Ghorai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70196 )
Change subject: mb/google/rex: Implement S0ix hooks aka `MS0X` method
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8:
I do see slp_s0 toggle 1st S0is after boot. may stay high hence sub-sequent s0ix cycle does not toggle. need to prob the signals.
Success log (1st S0ix):
[139.985900 ACPI kbli[139.988800 KB Clear Buffer]
22-12-02 10:59:18.752 [140.223000 HI: power state 16 = S0S0ix, in 0x00df
22-12-02 10:59:18.990 C 0x00a9]
22-12-02 10:59:18.991 [140.288100 lid-accel: 0: init failed: 1]
22-12-02 10:59:19.056 [140.290I: power state 5 = S0ix, in 0x00df
22-12-02 10:59:19.061 700 tcs3400_init failed reading ID reg 0x92, ret=1]
22-12-02 10:59:19.067 [140.292500 PD:S0->S3]
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70196
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie6b5e066f228ea5dc79ae14dd803fc283fd248ce
Gerrit-Change-Number: 70196
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Utkarsh H Patel
utkarsh.h.patel@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-CC: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-CC: Utkarsh H Patel
utkarsh.h.patel@intel.corp-partner.google.com
Gerrit-Attention: Utkarsh H Patel
utkarsh.h.patel@intel.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Utkarsh H Patel
utkarsh.h.patel@intel.com
Gerrit-Comment-Date: Fri, 02 Dec 2022 19:12:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment