Change in coreboot[master]: soc/intel/common: Add bootblock common stage file

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18457 )

Change subject: soc/intel/common: Add bootblock common stage file
......................................................................


Patch Set 38:

(2 comments)

https://review.coreboot.org/c/coreboot/+/18457/38/src/soc/intel/common/basec... 
File src/soc/intel/common/basecode/bootblock/bootblock.c:

https://review.coreboot.org/c/coreboot/+/18457/38/src/soc/intel/common/basec... 
PS38, Line 33: #if CONFIG(PLATFORM_USES_FSP1_1)
             : #include <fsp/bootblock.h>
             : #else
             : static inline void bootblock_fsp_temp_ram_init(void) {}
             : #endif
remove this


https://review.coreboot.org/c/coreboot/+/18457/38/src/soc/intel/common/basec... 
PS38, Line 124: 
i guess we have some fundamental mistake in this patch

Flow should be 

assembly code calling "bootblock_c_entry()"->call should come here in common bootblock->passes to bootblock_main_with_basetime() -> again from lib/bootblock.c it comes into common stage file here with dedicated code like this bootblock_soc_early_init/bootblock_soc_init/bootblock_pch_early_init/bootblock_pch_init/bootblock_cpu_early_init/bootblock_cpu_init -> Idea is to make all common operations across core/atom here and also provide a placeholder to perform any specific SoC related job like page table at line 93 (that code shouldn't be here)

So whoever debug can trace the flow easily and new SoC port job also reduced, if nothing specific to SoC code then bootblock.c won't even exist inside SoC directory.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/18457
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If84c08d33f6f8fd3cd9722ee893653f1d1ae90c1
Gerrit-Change-Number: 18457
Gerrit-PatchSet: 38
Gerrit-Owner: Subrata Banik <[e-mail]>
Gerrit-Reviewer: Aamir Bohra <[e-mail]>
Gerrit-Reviewer: Aaron Durbin <[e-mail]>
Gerrit-Reviewer: Bernardo Perez Priego <[e-mail]>
Gerrit-Reviewer: Martin Roth <[e-mail]>
Gerrit-Reviewer: Maulik V Vaghela <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Rizwan Qureshi <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: Usha P <[e-mail]>
Gerrit-Reviewer: V Sowmya <[e-mail]>
Gerrit-Reviewer: Varun Joshi <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Angel Pons <[e-mail]>
Gerrit-CC: Arthur Heymans <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Mon, 03 Feb 2020 11:08:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment