Attention is currently required from: Julius Werner, Jan Dabros. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56601 )
Change subject: tests: Add lib/cbfs-verification-test test case ......................................................................
Patch Set 2:
(3 comments)
File tests/lib/cbfs-verification-test.c:
https://review.coreboot.org/c/coreboot/+/56601/comment/99a00a5a_6fe02a75 PS2, Line 4: #define __noreturn
You're only changing the prototype of the function for this compilation unit though, other compilati […]
`fail()` in CMocka calls either `exit()`, `abort()` or `siglongjmp()`. The first two have `noreturn` attribute., so they are not problematic. However, I am not sure, if `siglongjmp()` also is `noreturn`, but it too should not cause problems.
https://review.coreboot.org/c/coreboot/+/56601/comment/70e54c27_116a26d3 PS2, Line 167: assert_null(mapping);
The problem with --add-symbol is, we have to know, what address of <functionname> is. […]
Done, I think. CL:56719
https://review.coreboot.org/c/coreboot/+/56601/comment/86426952_09f27c17 PS2, Line 181: assert_memory_equal(mapping, &test_data, TEST_DATA_SIZE);
nit: Feels a bit odd that you test pointer equality above and only content equality down here. […]
Assuming we do not use cache, we can. If it was a file, that is mapped through cbfs_cache, then it would not work. Are you sure, that this behavior is not going to be changed.
-
Jakub Czapiga (Code Review)