[XS] Change in coreboot[main]: mb/google/dedede/var/awasuki: Adjust touchpad I2C frequency - coreboot-gerrit

29 Oct 2024


      Attention is currently required from: Felix Held, Subrata Banik.
hualin wei has posted comments on this change by hualin wei. ( https://review.coreboot.org/c/coreboot/+/84898?usp=email )
Change subject: mb/google/dedede/var/awasuki: Adjust touchpad I2C frequency
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84898/comment/e699745a_eaa70e84?usp... :
PS1, Line 7:  to less than 400 KHz
...
remove, and elaborate in comment for why
Done
https://review.coreboot.org/c/coreboot/+/84898/comment/33af781c_a7462760?usp... :
PS1, Line 16: Frequency of the actual measured machine is pass
...
test with scope and check the wave?
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84898?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5ccaa3a669e18319311de14833966410c7adf40d
Gerrit-Change-Number: 84898
Gerrit-PatchSet: 3
Gerrit-Owner: hualin wei weihualin@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai ericllai@google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Weimin Wu wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 29 Oct 2024 03:30:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai ericllai@google.com