Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29917 )
Change subject: src: Remove unused variables
......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/#/c/29917/14//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/29917/14//COMMIT_MSG@7
PS14, Line 7: src: Remove unused variables
why did you fix it ?
Do you want to enable Wunused ?
https://review.coreboot.org/#/c/29917/14/src/southbridge/intel/fsp_rangeley/...
File src/southbridge/intel/fsp_rangeley/romstage.c:
https://review.coreboot.org/#/c/29917/14/src/southbridge/intel/fsp_rangeley/...
PS14, Line 123: printk(BIOS_DEBUG, "cbmem was initted\n");
good solution, but I only care about the error case.
Same for other cbmem_recovery invocations.
if (!cbmem_was_initted) printk(BIOS_ERR, ...)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29917
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibdfbf1031130ff861c4313d1271d6ccb68bf8837
Gerrit-Change-Number: 29917
Gerrit-PatchSet: 14
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
damien@zamaudio.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: York Yang
york.yang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 02 Dec 2018 08:41:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment