Change in coreboot[master]: sb/intel/common: Add function to automatically generate ACPI PIRQ

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/22803 )

Change subject: sb/intel/common: Add function to automatically generate ACPI PIRQ
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/22803/3/src/southbridge/intel/common/acpi_pi...
File src/southbridge/intel/common/acpi_pirq_gen.c:

https://review.coreboot.org/#/c/22803/3/src/southbridge/intel/common/acpi_pi...
PS3, Line 43: }
            :
> I'd suggest adding the acpigen here with a flag, so you can call this below

what about defining it as a macro?

https://review.coreboot.org/#/c/22803/3/src/southbridge/intel/common/acpi_pi...
PS3, Line 83: int_pin - 1
> pin to pirq mapping should be looked up in the register settings, in case i

I know but that is too much of a mess to implement. bailing out on non reset default DxxIR might be a good idea though...