Change in coreboot[master]: soc/intel/elkhartlake: Introduce Intel PSE

[Nico Huber (Code Review)]

Attention is currently required from: Arthur Heymans, Maulik V Vaghela, Mario Scheithauer, Subrata Banik, Lean Sheng Tan, Michael Niewöhner, Werner Zeh, Patrick Rudolph, Felix Held.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55367 )

Change subject: soc/intel/elkhartlake: Introduce Intel PSE
......................................................................


Patch Set 46: Code-Review-1

(1 comment)

Patchset:

PS46: 
As I understand the situation now, using the PSE is optional and
the program running on it can be open-source. Wouldn't it be much
better to treat it as open-source from the beginning? i.e. inte-
grate the mininum code into coreboot, so every board owner can
add the code they need.

If we treat it like a blob as this change currently does, we would
not only make it harder for board developers to add their code,
we'd also encourage proprietary implementations. IMHO, that's not
a direction a free-software project should move into. On top it
seems more expensive for everyone, especially for the coreboot
community. We'd not only have to maintain the option to load a
blob that shouldn't be one, we'd also have to handle support re-
quests if something goes wrong with it. Helping somebody with
their proprietary blob is not fun, helping somebody to integrate
their open-source code is!



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/55367
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifea08fb82fea18ef66bab04b3ce378e79a0afbf7
Gerrit-Change-Number: 55367
Gerrit-PatchSet: 46
Gerrit-Owner: Lean Sheng Tan <[e-mail]>
Gerrit-Reviewer: Mario Scheithauer <[e-mail]>
Gerrit-Reviewer: Maulik V Vaghela <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: Werner Zeh <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC:  Felix Singer <[e-mail]>
Gerrit-CC: Angel Pons <[e-mail]>
Gerrit-CC: Arthur Heymans <[e-mail]>
Gerrit-CC: Arthur Heymans <[e-mail]>
Gerrit-CC: Felix Held <[e-mail]>
Gerrit-CC: Michael Niewöhner <[e-mail]>
Gerrit-Attention: Arthur Heymans <[e-mail]>
Gerrit-Attention: Maulik V Vaghela <[e-mail]>
Gerrit-Attention: Mario Scheithauer <[e-mail]>
Gerrit-Attention: Subrata Banik <[e-mail]>
Gerrit-Attention: Arthur Heymans <[e-mail]>
Gerrit-Attention: Lean Sheng Tan <[e-mail]>
Gerrit-Attention: Michael Niewöhner <[e-mail]>
Gerrit-Attention: Werner Zeh <[e-mail]>
Gerrit-Attention: Patrick Rudolph <[e-mail]>
Gerrit-Attention: Felix Held <[e-mail]>
Gerrit-Comment-Date: Wed, 03 Nov 2021 13:41:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment