Attention is currently required from: Anil Kumar K, Eric Lai, Jérémy Compostella, Nick Vaccaro, Subrata Banik.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78502?usp=email )
Change subject: mb/{google,intel}: Update FMD to support CBFS verification
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/mainboard/google/dedede/chromeos-dedede-16MiB.fmd:
https://review.coreboot.org/c/coreboot/+/78502/comment/bd80fe13_cd6500f5 :
PS2, Line 12: ME_RW_A(CBFS)@0x214800 0x190000
I updated patch to fix the offsets for boards that are using them. […]
I mean, I really think it would be better to just get rid of the hardcoded offsets entirely, but sure, this works.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78502?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3ca88fee181f059852923d50292b24c0e5b9fd6d
Gerrit-Change-Number: 78502
Gerrit-PatchSet: 3
Gerrit-Owner: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Tue, 31 Oct 2023 00:25:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Anil Kumar K
anil.kumar.k@intel.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment