Attention is currently required from: Francois Toguo Fotso, Furquan Shaikh, Tim Wawrzynczak, Karthik Ramasubramanian. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57785 )
Change subject: soc/intel/block: Add small crashlog helper library ......................................................................
Patch Set 3:
(3 comments)
File src/soc/intel/common/block/crashlog/crashlog_lib.c:
https://review.coreboot.org/c/coreboot/+/57785/comment/baa33f34_00eaaa2f PS3, Line 4: #include "crashlog_lib.h" nit - local "" includes should follow system <> includes ordering-wise, with blank line between the the system includes and the local include sections.
https://review.coreboot.org/c/coreboot/+/57785/comment/247d9381_0504b42c PS3, Line 10: size_t Why is this a size_t?
https://review.coreboot.org/c/coreboot/+/57785/comment/2b52f44a_e973e266 PS3, Line 30: next_pos Is this needed? Why not set pos directly?
-
Nick Vaccaro (Code Review)