Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Paul Menzel, Kyösti Mälkki, Fred Reitberger, Felix Held.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64498 )
Change subject: soc/amd: Do SMM relocation via MSR
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/common/Kconfig.common:
https://review.coreboot.org/c/coreboot/+/64498/comment/1a2094b8_b96e739b
PS1, Line 9: X86_SMM_NO_RELOCATION_HANDLER
i preferred the version with the negative logic. the default there was is n and the socs wanting to use this feature can just select the option which i find more intuitive. now it's the unexpected way around
I'm planning to create common code for AMD mp init and they will all use the MSR feature so it's basically intel vs amd. Whether to use a relocation handler then just becomes an historical artifact and it does not matter what the default is as it is set in all cases.
Ping
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64498
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I31d4d4ae20e09da5739b6bf56e7b66857b4f1afe
Gerrit-Change-Number: 64498
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 31 May 2022 20:34:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment