Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Paul Menzel, Tarun.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79330?usp=email )
Change subject: mb/google/rex/var/screebo: Override power limits
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79330/comment/7778412b_673e9add :
PS3, Line 21: [INFO ] Overriding power limits PL1 (mW) (10000, 15000)
: PL2 (mW) (40000, 40000) PL4 (W) (84)
:
: After:
:
: [INFO ] Overriding power limits PL1 (mW) (10000, 15000)
: PL2 (mW) (40000, 40000) PL4 (W) (84)
Thank you for the explanation. So, the paste demonstrate that the debug line is gone?
exactly the `DEBUG` line suggests that, we were using baseline default value (aka no override). And modified CL shows that we are using an overridden value from variant directory.
I was confused by “This patch modifies the power limits value to enhance …” in the beginning. But no power limits are changed?
updated the commit msg.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79330?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic66872c530963238a0bf5eebbd5b5a76a7985e5c
Gerrit-Change-Number: 79330
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Sun, 03 Dec 2023 01:49:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment