Attention is currently required from: Johnny Lin.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75510?usp=email )
Change subject: drivers/ocp/vpd: Overwrite Linux payload's kernel command via VPD
......................................................................
Patch Set 6:
(1 comment)
File src/drivers/ocp/vpd/vpd_cmdline.c:
https://review.coreboot.org/c/coreboot/+/75510/comment/b228d6fb_6d85b3e1 :
PS6, Line 21: printk(BIOS_INFO, "Invalid VPD for Linux kernel log level\n");
Sorry for the confusion. I meant to print the invalid value here. Also the level should be *warning* or at least *notice*.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75510?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf06c7ab9958c940fc3b23d560bb9dade991a6da
Gerrit-Change-Number: 75510
Gerrit-PatchSet: 6
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nill Ge
geshijian@bytedance.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Shelly Chang
Shelly_Chang@wiwynn.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Chen, Gang C
gang.c.chen@intel.com
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Comment-Date: Thu, 01 Jun 2023 13:44:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment