Attention is currently required from: Nico Huber, Subrata Banik, Angel Pons, Arthur Heymans.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64076 )
Change subject: src/soc/intel/cmn/fast-spi: Add SSDT extension to fast SPI driver
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/fast_spi/fast_spi.c:
https://review.coreboot.org/c/coreboot/+/64076/comment/2dbcbe83_944119f4
PS2, Line 486: !CONFIG(SOC_INTEL_APOLLOLAKE)
IMO, the best option is 4. don't have common `device_operations`. It always […]
Is it really in scope here? Going away from the common driver approach to a soc specific one while duplicating the code all the way down for every soc? I know that in this case it is mostly Apollo Lake that is badly designed here. Though we have a few ways to go to handle it in the common code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64076
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia16dfe6e001188aad26418afe0f04c53ecfd56f1
Gerrit-Change-Number: 64076
Gerrit-PatchSet: 2
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 09 May 2022 20:47:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment