Attention is currently required from: Bora Guvendik, Kapil Porwal, Pranava Y N, Subrata Banik, Wonkyu Kim.
Elyes Haouas has posted comments on this change by Bora Guvendik. ( https://review.coreboot.org/c/coreboot/+/84872?usp=email )
Change subject: soc/intel/pantherlake: Simplify Panther Lake's pre-cpu time ......................................................................
Patch Set 6:
(2 comments)
File src/mainboard/google/fatcat/Kconfig:
https://review.coreboot.org/c/coreboot/+/84872/comment/2fc2c810_91686a3d?usp... : PS6, Line 34: SOC_INTEL_CSE_PRE_CPU_RESET_TELEMETRY isn't this already selected through
`config SOC_INTEL_CSE_PRE_CPU_RESET_TELEMETRY_V1 bool select SOC_INTEL_CSE_PRE_CPU_RESET_TELEMETRY help This config will make mainboard use version 1 of the CSE timestamp definitions, it can be used for Alder Lake and Raptor Lake (all SKUs).
config SOC_INTEL_CSE_PRE_CPU_RESET_TELEMETRY_V2 bool select SOC_INTEL_CSE_PRE_CPU_RESET_TELEMETRY help This config will make mainboard use version 2 of the CSE timestamp definitions, it can be used for Meteor Lake M/P.
` ?
File src/soc/intel/pantherlake/cse_telemetry.c:
https://review.coreboot.org/c/coreboot/+/84872/comment/fec392b7_fb8f5856?usp... : PS6, Line 9: #define PERF_DATA_CSME_GET_PERF_RESPONSE 63 I'm confused. This already defined as 63, isn't it?