Attention is currently required from: Anil Kumar K, Jérémy Compostella, Krishna P Bhat D, Paul Menzel.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78243?usp=email )
Change subject: soc/intel/cse: Add API to check if CSE Firmware update is required
......................................................................
Patch Set 14:
(1 comment)
Patchset:
PS14:
As I was testing this feature, I added timestamps around this function call and it takes about 17 ms to execute.
17ms on everyboot is costly IMO. Can you please talk to Krishna/Rizwan as they were implementing some persistant variable to avoid calling into CSE version in all boot instances. That effort will help to save the boot time IMO
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78243?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If5fae95786d28d586566881bc4436812754636ae
Gerrit-Change-Number: 78243
Gerrit-PatchSet: 14
Gerrit-Owner: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-CC: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Comment-Date: Tue, 31 Oct 2023 02:59:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-MessageType: comment