Change in coreboot[master]: lenovo/x230t: Use INPUT mode for gpio33 as per discussion

[Damien Zammit (Code Review)]

Damien Zammit has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34362 )

Change subject: lenovo/x230t: Use INPUT mode for gpio33 as per discussion
......................................................................

lenovo/x230t: Use INPUT mode for gpio33 as per discussion

Change-Id: Ieb262f38520aa04c65fb8da73e22c96ae510e3eb
Signed-off-by: Damien Zammit 
---
M src/mainboard/lenovo/x230t/gpio.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/34362/1

diff --git a/src/mainboard/lenovo/x230t/gpio.c b/src/mainboard/lenovo/x230t/gpio.c
index 7e60e76..c84ba73 100644
--- a/src/mainboard/lenovo/x230t/gpio.c
+++ b/src/mainboard/lenovo/x230t/gpio.c
@@ -133,7 +133,7 @@
 };

static const struct pch_gpio_set2 pch_gpio_set2_direction = {
-	.gpio33 = GPIO_DIR_OUTPUT,
+	.gpio33 = GPIO_DIR_INPUT,
    .gpio34 = GPIO_DIR_INPUT,
    .gpio35 = GPIO_DIR_INPUT,
    .gpio36 = GPIO_DIR_INPUT,

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34362 )

Change subject: lenovo/x230t: Use INPUT mode for gpio33 as per discussion
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34362/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34362/1//COMMIT_MSG@8 
PS1, Line 8: 
Please summarize the discussion.

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34362 )

Change subject: lenovo/x230t: Use INPUT mode for gpio33 as per discussion
......................................................................

Patch Set 1:

I'd just squash it on the parent change, and leave a comment w.r.t. the GPIO

[Damien Zammit (Code Review)]

Damien Zammit has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34362 )

Change subject: lenovo/x230t: Use INPUT mode for gpio33 as per discussion
......................................................................

Abandoned

Not needed