Attention is currently required from: Ivy Jian, Karthik Ramasubramanian.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79392?usp=email )
Change subject: mb/google/brox: Generate RAM IDs ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/brox/variants/brox/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/79392/comment/e45e1de2_8e667032 : PS1, Line 4: /tmp/go-build3467193440/b001/exe/part_id_gen same here
File src/mainboard/google/brox/variants/brox/memory/dram_id.generated.txt:
https://review.coreboot.org/c/coreboot/+/79392/comment/fcaf33de_8c5cb91d : PS1, Line 4: /tmp/go-build3467193440/b001/exe/part_id_gen Did you use a local copy of the script? I'd rather keep the path to the common script in the repo so that the message is helpful to everyone. Any chance that you can regenerate with the common script to fix this comment?