Attention is currently required from: Alexander Couzens, Angel Pons, Keith Hui.
Cleyton Silva has posted comments on this change by Cleyton Silva. ( https://review.coreboot.org/c/coreboot/+/83670?usp=email )
Change subject: mb/lenovo: Add IH61M mainboard ......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83670/comment/071d9d27_58ba17d4?usp... : PS1, Line 13: 2MB+4MB
This doesn't show the flash chip order, though. Can you please show the output of `. […]
I don't know why ifdtool is showing the regions out of order, besides gbe and pd which aren't even used on this board, but the hex addresses where each region starts/ends are correct, organized like this...
00000000:00000fff fd 00001000:001fffff me 00200000:005fffff bios
./util/ifdtool -d bkp-lenovo-h61.rom > https://pastebin.com/raw/Yx7jbv7r
https://review.coreboot.org/c/coreboot/+/83670/comment/6c2f023c_9004963f?usp... : PS1, Line 43: - Internal flashing : - External flashing (in-circuit)
Nice! Isn't it convenient that UEFI code reuse leads to exploit reuse? 😄 […]
Very convenient! =)
Okay, I'll make another separate commit later to document the flashing for this board. Thanks, Angel!
File src/mainboard/lenovo/ih61m/Kconfig:
https://review.coreboot.org/c/coreboot/+/83670/comment/980a10f3_8a4f633e?usp... : PS4, Line 23: config MAINBOARD_PART_NUMBER : default "IH61M Ver:1.0" if BOARD_LENOVO_IH61M_V1 : default "IH61M Ver:4.2" if BOARD_LENOVO_IH61M_V4
Would it make more sense to set `MAINBOARD_VERSION` instead? […]
Acknowledged
File src/mainboard/lenovo/ih61m/early_init.c:
https://review.coreboot.org/c/coreboot/+/83670/comment/77bf4eb6_639144ad?usp... : PS4, Line 27: pnp_set_logical_device(SERIAL_DEV);
This shouldn't be needed, `nuvoton_enable_serial` already switches to `SERIAL_DEV`
Acknowledged