Paul Fagerburg has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48129 )
Change subject: util/mb/google/puff: remove HECI from overridetree ......................................................................
util/mb/google/puff: remove HECI from overridetree
The template for overridetree.cb includes HeciEnabled, which has been removed from the CNL config struct, so remove it from the overridetree.
BUG=b:174360951 TEST=`new_variant_fulltest.sh puff` succeeds
Change-Id: I87f67c53cc75d9ddd40b4960739180a95de6ecd6 --- M util/mainboard/google/puff/template/overridetree.cb 1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/48129/1
diff --git a/util/mainboard/google/puff/template/overridetree.cb b/util/mainboard/google/puff/template/overridetree.cb index adb00e4..a30dad0 100644 --- a/util/mainboard/google/puff/template/overridetree.cb +++ b/util/mainboard/google/puff/template/overridetree.cb @@ -1,7 +1,4 @@ chip soc/intel/cannonlake - # Enable heci communication - register "HeciEnabled" = "1" - # Auto-switch between X4 NVMe and X2 NVMe. register "TetonGlacierMode" = "1"
Hello build bot (Jenkins), Edward O'Callaghan, Andrew McRae,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48129
to look at the new patch set (#2).
Change subject: util/mb/google/puff: remove HECI from overridetree ......................................................................
util/mb/google/puff: remove HECI from overridetree
The template for overridetree.cb includes HeciEnabled, which has been removed from the CNL config struct, so remove it from the overridetree.
BUG=b:174360951 TEST=`new_variant_fulltest.sh puff` succeeds
Signed-off-by: Paul Fagerburg pfagerburg@google.com Change-Id: I87f67c53cc75d9ddd40b4960739180a95de6ecd6 --- M util/mainboard/google/puff/template/overridetree.cb 1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/48129/2
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48129 )
Change subject: util/mb/google/puff: remove HECI from overridetree ......................................................................
Patch Set 2: Code-Review+2
Paul Fagerburg has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48129 )
Change subject: util/mb/google/puff: remove HECI from overridetree ......................................................................
util/mb/google/puff: remove HECI from overridetree
The template for overridetree.cb includes HeciEnabled, which has been removed from the CNL config struct, so remove it from the overridetree.
BUG=b:174360951 TEST=`new_variant_fulltest.sh puff` succeeds
Signed-off-by: Paul Fagerburg pfagerburg@google.com Change-Id: I87f67c53cc75d9ddd40b4960739180a95de6ecd6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48129 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Edward O'Callaghan quasisec@chromium.org --- M util/mainboard/google/puff/template/overridetree.cb 1 file changed, 0 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved
diff --git a/util/mainboard/google/puff/template/overridetree.cb b/util/mainboard/google/puff/template/overridetree.cb index adb00e4..a30dad0 100644 --- a/util/mainboard/google/puff/template/overridetree.cb +++ b/util/mainboard/google/puff/template/overridetree.cb @@ -1,7 +1,4 @@ chip soc/intel/cannonlake - # Enable heci communication - register "HeciEnabled" = "1" - # Auto-switch between X4 NVMe and X2 NVMe. register "TetonGlacierMode" = "1"
-
Edward O'Callaghan (Code Review) -
Paul Fagerburg (Code Review)