Attention is currently required from: Angel Pons.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54974 )
Change subject: util/intelp2m/fsp: Update some deprecated macros
......................................................................
Patch Set 4:
(2 comments)
File util/intelp2m/fields/fsp/fsp.go:
https://review.coreboot.org/c/coreboot/+/54974/comment/6b15d9a9_723e621c
PS3, Line 125: 1: "GpioHostDeepReset",
: 2: "GpioPlatformReset",
: 3: "GpioResumeReset",
It seemed to me that fsp and edk2-platform use the same macros as intel reference bios, but I was wr […]
Not a problem.
https://review.coreboot.org/c/coreboot/+/54974/comment/2f0650c1_b3de83a9
PS3, Line 128: },
Please could you add a comment about Coffee Lake and GpioResetPwrGood?
Should I add the comment to the code as well?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54974
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab0bb09adad997bef3a2133c443471d4c634f423
Gerrit-Change-Number: 54974
Gerrit-PatchSet: 4
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 12 Jun 2021 20:20:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-MessageType: comment