[L] Change in coreboot[main]: mainboard: add Dell Latitude E7240

[Nicholas Chin (Code Review)]

Attention is currently required from: Arthur Heymans, Felix Singer, Iru Cai, Paul Menzel.

Nicholas Chin has posted comments on this change by Iru Cai. ( https://review.coreboot.org/c/coreboot/+/79746?usp=email )

Change subject: mainboard: add Dell Latitude E7240
......................................................................

Patch Set 6:

(8 comments)

Patchset:

PS3:
> Thanks! Do you think it's ready to submit?

The code seems fine to me, though it would be nice to get this boot tested again. I don't have this system.

File src/mainboard/dell/e7240/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/79746/comment/2164100b_ba4d5bf3?usp... :
PS5, Line 5: 	register "gfx" = "GMA_STATIC_DISPLAYS(0)"
           : 	register "gpu_ddi_e_connected" = "0"
           : 	register "gpu_dp_b_hotplug" = "4"
           : 	register "gpu_dp_c_hotplug" = "4"
           : 	register "gpu_dp_d_hotplug" = "4"
           : 	register "panel_cfg" = "{
           : 		.up_delay_ms		= 200,
           : 		.down_delay_ms		=  50,
           : 		.cycle_delay_ms		= 500,
           : 		.backlight_on_delay_ms	=   1,
           : 		.backlight_off_delay_ms	=   1,
           : 		.backlight_pwm_hz	= 200,
           : 	}"
> Move into iGPU device scope

Done

https://review.coreboot.org/c/coreboot/+/79746/comment/cc29517b_5b6727f4?usp... :
PS5, Line 32: 			register "gen1_dec" = "0x007c0681"
            : 			register "gen2_dec" = "0x005c0921"
            : 			register "gen3_dec" = "0x003c07e1"
            : 			# Enable 0x910 and 0x911 for early init and EC driver
            :
> Move into LPC device scope

Done

https://review.coreboot.org/c/coreboot/+/79746/comment/a75a1dd2_ada8bd44?usp... :
PS5, Line 43: 			# 0(eSATA on dock), 1(mSATA near the fan), 3(mSATA near WLAN)
            :
> Move into SATA device scope

Done

File src/mainboard/dell/e7240/hda_verb.c:

https://review.coreboot.org/c/coreboot/+/79746/comment/205deaf2_e10d2898?usp... :
PS5, Line 11: 	AZALIA_PIN_CFG(0, 0x13, 0x411111f0),
>

Done

https://review.coreboot.org/c/coreboot/+/79746/comment/7c8b578b_f31889a7?usp... :
PS5, Line 15: 	AZALIA_PIN_CFG(0, 0x18, 0x411111f0),
>

Done

https://review.coreboot.org/c/coreboot/+/79746/comment/87047389_d2c74c03?usp... :
PS5, Line 17: 	AZALIA_PIN_CFG(0, 0x1a, 0x411111f0),
            : 	A
>

Done

https://review.coreboot.org/c/coreboot/+/79746/comment/4f1e6db4_7e8bd038?usp... :
PS5, Line 20: 0x411111f0
>

Done