Change in coreboot[master]: console: Add loglevel prefix to interactive consoles
Attention is currently required from: Nico Huber, Patrick Georgi, Julius Werner, Kyösti Mälkki. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61306 ) Change subject: console: Add loglevel prefix to interactive consoles ...................................................................... Patch Set 5: (1 comment) File src/console/printk.c: https://review.coreboot.org/c/coreboot/+/61306/comment/f980eb10_851515ee PS5, Line 80: console_interactive_tx_byte
Can we use `vtxprintf(interactive_putchar, BIOS_LOG_PREFIX_PATTERN, &bios_log_prefix[state. […] Might be cleaner to add a `static interactive_printk(fmt, args)`. Then you can use the format specifiers for the styling as well.
-- To view, visit https://review.coreboot.org/c/coreboot/+/61306 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic83413475400821f8097ef1819a293ee8926bb0b Gerrit-Change-Number: 61306 Gerrit-PatchSet: 5 Gerrit-Owner: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick@coreboot.org> Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Nico Huber <nico.h@gmx.de> Gerrit-Attention: Patrick Georgi <patrick@coreboot.org> Gerrit-Attention: Julius Werner <jwerner@chromium.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-Comment-Date: Thu, 03 Feb 2022 16:23:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel@chromium.org> Gerrit-MessageType: comment
participants (1)
-
Raul Rangel (Code Review)