Attention is currently required from: Cliff Huang, Lance Zhao, Matt DeVillier, Raul Rangel, Tim Wawrzynczak.
Hello Cliff Huang, Lance Zhao, Matt DeVillier, Tim Wawrzynczak, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79219?usp=email
to look at the new patch set (#3).
Change subject: acpi/acpi: add & use ACPI_DBG2_PORT_SERIAL_16550_GENERIC ......................................................................
acpi/acpi: add & use ACPI_DBG2_PORT_SERIAL_16550_GENERIC
The Microsoft Debug Port Table 2 (DBG2) specification says that the serial port subtype 0x00 should only be used for I/O-mapped 16550 compatible UARTs. The subtype 0x12 is a superset of that, and supports specifying MMIO vs IO and the register access size via the generic address structure. Rename the subtype 0x00 definition to ACPI_DBG2_PORT_SERIAL_16550_IO_ONLY and add the subtype 0x12 definition as new ACPI_DBG2_PORT_SERIAL_16550, so that the acpi_write_dbg2_uart function will write the correct subtype for the generic 16550 UART.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I816bb22e6f76e661c8b8e39a2a4cb83b0085acb5 --- M src/include/acpi/acpi.h 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/79219/3