[L] Change in coreboot[main]: ec/dasharo/ec: add Dasharo features

[Michał Kopeć (Code Review)]

Attention is currently required from: Felix Singer, Krystian Hebel, Maciej Pijanowski, Michał Żygowski.

Michał Kopeć has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/82672?usp=email )

Change subject: ec/dasharo/ec: add Dasharo features
......................................................................

Patch Set 13:

(7 comments)

File src/ec/dasharo/ec/dasharo_ec.c:

https://review.coreboot.org/c/coreboot/+/82672/comment/baf5f451_a21ccd9b?usp... :
PS10, Line 17: #define DASHARO_EC_BASE 0x0E00
> Is this reserved from resource allocator?

Doesn't seem to be. It's only programmed in genX_dec in devicetree

https://review.coreboot.org/c/coreboot/+/82672/comment/aed0543b_d3c4e9a2?usp... :
PS10, Line 88: index should be valid due to length test above
> I don't see such test. […]

Removed in latest patchset. EC update still needs some work and debugging, let's not block merging this on that feature

https://review.coreboot.org/c/coreboot/+/82672/comment/c5d5144c_1fe5616c?usp... :
PS10, Line 122: 	// Read data bytes, index should be valid due to length test above
> Same as `dasharo_ec_read_version`.

This code was removed

https://review.coreboot.org/c/coreboot/+/82672/comment/0c4836a3_a7672aac?usp... :
PS10, Line 292: 	if ((rv = ec_spi_reset()))
> I don't know how this EC works, but I assume that this reset doesn't clear SPI status, right?

This code was removed

https://review.coreboot.org/c/coreboot/+/82672/comment/0e6dce12_9193195c?usp... :
PS10, Line 323: 	return 0;
> This and next function return 0 also when `status < 0`, is this the expected behavior?

This code was removed

https://review.coreboot.org/c/coreboot/+/82672/comment/5bb73ca8_80f13b1f?usp... :
PS10, Line 553: dasharo_ec_read_board((uint8_t *)cur_board_str);
              : 	dasharo_ec_read_version((uint8_t *)cur_version_str);
> Return values are not checked, which makes `cur_*_str` potentially uninitialized.

This code was removed

https://review.coreboot.org/c/coreboot/+/82672/comment/c7862b09_cdeb9a87?usp... :
PS10, Line 570: 	if ((ec_read(0x10) & 0x01) != 0x01) {
> Magic numbers, please at least add a comment about their meaning.

This code was removed