Attention is currently required from: Bora Guvendik, Martin Roth, Tim Wawrzynczak, Paul Menzel, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51446 )
Change subject: soc/intel/alderlake: Inject Pre-CPU reset TS into timestamp_table
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/alderlake/telemetry.c:
https://review.coreboot.org/c/coreboot/+/51446/comment/5e0f5cfc_52e685d2
PS5, Line 97: for (; hob && hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) {
: if (hob->type != HOB_TYPE_GUID_EXTENSION)
: continue;
:
: res = fsp_hob_header_to_resource(hob);
:
: if (fsp_guid_compare(res->owner_guid, fsp_me_bios_payload_hob_guid)) {
: get_pre_reset_ts_from_hob(hob);
: return;
: }
: }
I think this just could be: […]
Thanks Tim for your review, I will be joining back office from June 1st after my vacation for over. will address your feedback and ones in tree.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51446
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b7728d3da0d38dc0f1b465743486025dcf354b3
Gerrit-Change-Number: 51446
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 27 May 2021 22:12:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment