Change in coreboot[master]: mb/google/hatch/variants/helios: Update TSR3 sensor thresholds
Sumeet R Pawnikar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36609 )
Change subject: mb/google/hatch/variants/helios: Update TSR3 sensor thresholds ......................................................................
mb/google/hatch/variants/helios: Update TSR3 sensor thresholds
Update thermal threshold settings for TSR3 sensor. There is an issue fan is alwyas running, even during system idle state. This change fix this issue and fan starts only when it breaches the temperature thershold.
BRANCH=None BUG=b:143861559 TEST=Built and tested on Helios system
Change-Id: Ia417f8c51442005cc8c2251c188cebc197e0a773 Signed-off-by: Sumeet Pawnikar sumeet.r.pawnikar@intel.com --- M src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl 1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/36609/1
diff --git a/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl b/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl index 9094352..20a61d7 100644 --- a/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl +++ b/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl @@ -36,14 +36,14 @@
#define DPTF_TSR3_SENSOR_ID 3 #define DPTF_TSR3_SENSOR_NAME "CPU" -#define DPTF_TSR3_PASSIVE 85 -#define DPTF_TSR3_CRITICAL 100 -#define DPTF_TSR3_ACTIVE_AC0 0 -#define DPTF_TSR3_ACTIVE_AC1 0 -#define DPTF_TSR3_ACTIVE_AC2 0 -#define DPTF_TSR3_ACTIVE_AC3 0 -#define DPTF_TSR3_ACTIVE_AC4 0 -#define DPTF_TSR3_ACTIVE_AC5 0 +#define DPTF_TSR3_PASSIVE 90 +#define DPTF_TSR3_CRITICAL 105 +#define DPTF_TSR3_ACTIVE_AC0 87 +#define DPTF_TSR3_ACTIVE_AC1 85 +#define DPTF_TSR3_ACTIVE_AC2 83 +#define DPTF_TSR3_ACTIVE_AC3 80 +#define DPTF_TSR3_ACTIVE_AC4 78 +#define DPTF_TSR3_ACTIVE_AC5 75
#define DPTF_ENABLE_CHARGER #define DPTF_ENABLE_FAN_CONTROL
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36609 )
Change subject: mb/google/hatch/variants/helios: Update TSR3 sensor thresholds ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36609/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36609/1//COMMIT_MSG@10 PS1, Line 10: alwyas always
https://review.coreboot.org/c/coreboot/+/36609/1//COMMIT_MSG@11 PS1, Line 11: fix fixes
https://review.coreboot.org/c/coreboot/+/36609/1//COMMIT_MSG@12 PS1, Line 12: thershold threshold
Hello Aaron Durbin, Philip Chen, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Scott Collyer, Furquan Shaikh, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36609
to look at the new patch set (#2).
Change subject: mb/google/hatch/variants/helios: Update TSR3 sensor thresholds ......................................................................
mb/google/hatch/variants/helios: Update TSR3 sensor thresholds
Update thermal threshold settings for TSR3 sensor. There is an issue fan is always running, even during system idle state. This change fixes this issue and fan starts only when it breaches the temperature threshold.
BRANCH=None BUG=b:143861559 TEST=Built and tested on Helios system
Change-Id: Ia417f8c51442005cc8c2251c188cebc197e0a773 Signed-off-by: Sumeet Pawnikar sumeet.r.pawnikar@intel.com --- M src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl 1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/36609/2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36609 )
Change subject: mb/google/hatch/variants/helios: Update TSR3 sensor thresholds ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36609/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/36609/2/src/mainboard/google/hatch/... PS2, Line 39: #define DPTF_TSR3_PASSIVE 90 : #define DPTF_TSR3_CRITICAL 105 : #define DPTF_TSR3_ACTIVE_AC0 87 : #define DPTF_TSR3_ACTIVE_AC1 85 : #define DPTF_TSR3_ACTIVE_AC2 83 : #define DPTF_TSR3_ACTIVE_AC3 80 : #define DPTF_TSR3_ACTIVE_AC4 78 : #define DPTF_TSR3_ACTIVE_AC5 75 I thought when the thresholds were set to 0, that meant the the particular threshold was not used? Did the 5 degree change in both _PASSIVE and _CRITICAL make that much of a difference?
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36609 )
Change subject: mb/google/hatch/variants/helios: Update TSR3 sensor thresholds ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36609/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/36609/2/src/mainboard/google/hatch/... PS2, Line 39: #define DPTF_TSR3_PASSIVE 90 : #define DPTF_TSR3_CRITICAL 105 : #define DPTF_TSR3_ACTIVE_AC0 87 : #define DPTF_TSR3_ACTIVE_AC1 85 : #define DPTF_TSR3_ACTIVE_AC2 83 : #define DPTF_TSR3_ACTIVE_AC3 80 : #define DPTF_TSR3_ACTIVE_AC4 78 : #define DPTF_TSR3_ACTIVE_AC5 75
I thought when the thresholds were set to 0, that meant the the particular threshold was not used? […]
These are temperature thresholds values. When these are set to 0, it means when current TSR3 sensor temperature above 0 as per below DART at line 102, fan will start running as per 30 value. This means once system starts/boots TSR3 sensor temperature will be always above 0 degree and fan will be always running. 5 degree change in both _PASSIVE and _CRITICAL are initial values, we might need to fine tune on DVT systems once available.
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36609 )
Change subject: mb/google/hatch/variants/helios: Update TSR3 sensor thresholds ......................................................................
Patch Set 2: Code-Review+2
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36609 )
Change subject: mb/google/hatch/variants/helios: Update TSR3 sensor thresholds ......................................................................
Patch Set 2: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36609 )
Change subject: mb/google/hatch/variants/helios: Update TSR3 sensor thresholds ......................................................................
Patch Set 2: Code-Review+2
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36609 )
Change subject: mb/google/hatch/variants/helios: Update TSR3 sensor thresholds ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36609/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36609/1//COMMIT_MSG@10 PS1, Line 10: alwyas
always
Ack
https://review.coreboot.org/c/coreboot/+/36609/1//COMMIT_MSG@11 PS1, Line 11: fix
fixes
Ack
https://review.coreboot.org/c/coreboot/+/36609/1//COMMIT_MSG@12 PS1, Line 12: thershold
threshold
Ack
https://review.coreboot.org/c/coreboot/+/36609/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/36609/2/src/mainboard/google/hatch/... PS2, Line 39: #define DPTF_TSR3_PASSIVE 90 : #define DPTF_TSR3_CRITICAL 105 : #define DPTF_TSR3_ACTIVE_AC0 87 : #define DPTF_TSR3_ACTIVE_AC1 85 : #define DPTF_TSR3_ACTIVE_AC2 83 : #define DPTF_TSR3_ACTIVE_AC3 80 : #define DPTF_TSR3_ACTIVE_AC4 78 : #define DPTF_TSR3_ACTIVE_AC5 75
These are temperature thresholds values. […]
Ack
Shelley Chen has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36609 )
Change subject: mb/google/hatch/variants/helios: Update TSR3 sensor thresholds ......................................................................
mb/google/hatch/variants/helios: Update TSR3 sensor thresholds
Update thermal threshold settings for TSR3 sensor. There is an issue fan is always running, even during system idle state. This change fixes this issue and fan starts only when it breaches the temperature threshold.
BRANCH=None BUG=b:143861559 TEST=Built and tested on Helios system
Change-Id: Ia417f8c51442005cc8c2251c188cebc197e0a773 Signed-off-by: Sumeet Pawnikar sumeet.r.pawnikar@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36609 Reviewed-by: Duncan Laurie dlaurie@chromium.org Reviewed-by: Shelley Chen shchen@google.com Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl 1 file changed, 8 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Furquan Shaikh: Looks good to me, approved Shelley Chen: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl b/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl index 9094352..20a61d7 100644 --- a/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl +++ b/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl @@ -36,14 +36,14 @@
#define DPTF_TSR3_SENSOR_ID 3 #define DPTF_TSR3_SENSOR_NAME "CPU" -#define DPTF_TSR3_PASSIVE 85 -#define DPTF_TSR3_CRITICAL 100 -#define DPTF_TSR3_ACTIVE_AC0 0 -#define DPTF_TSR3_ACTIVE_AC1 0 -#define DPTF_TSR3_ACTIVE_AC2 0 -#define DPTF_TSR3_ACTIVE_AC3 0 -#define DPTF_TSR3_ACTIVE_AC4 0 -#define DPTF_TSR3_ACTIVE_AC5 0 +#define DPTF_TSR3_PASSIVE 90 +#define DPTF_TSR3_CRITICAL 105 +#define DPTF_TSR3_ACTIVE_AC0 87 +#define DPTF_TSR3_ACTIVE_AC1 85 +#define DPTF_TSR3_ACTIVE_AC2 83 +#define DPTF_TSR3_ACTIVE_AC3 80 +#define DPTF_TSR3_ACTIVE_AC4 78 +#define DPTF_TSR3_ACTIVE_AC5 75
#define DPTF_ENABLE_CHARGER #define DPTF_ENABLE_FAN_CONTROL
-
Duncan Laurie (Code Review) -
Furquan Shaikh (Code Review)
-
Paul Menzel (Code Review)
-
Shelley Chen (Code Review)
-
Sumeet R Pawnikar (Code Review)
-
Tim Wawrzynczak (Code Review)