Change in coreboot[master]: superio/aspeed/common: Add early configure functions - coreboot-gerrit

28 Apr 2020


      Bryant Ou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40483 )
Change subject: superio/aspeed/common: Add early configure functions
......................................................................
Patch Set 5:
...
Patch Set 5:
Bryant, I checked the patch and works fine with port80 and serial1. But enable for serial2 does not seem to work
After enable serial 2 (0x2f8), the FSP seems to output messages via 0x2f8 and encountered problems, so I couldn't see the messages on SOL. However, I did try to enable serial 3 (0x2e8), function looks good. Could you help to check FSP to see if it can disable debug messages?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40483
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib59c29a042b2c7bf196b8a5bd5218704d8075855
Gerrit-Change-Number: 40483
Gerrit-PatchSet: 5
Gerrit-Owner: Bryant Ou bryant.ou.q@gmail.com
Gerrit-Reviewer: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Ryback Hung ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Christian Walter christian.walter@9elements.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 28 Apr 2020 02:11:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment