Attention is currently required from: Martin Roth. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49672 )
Change subject: drivers/51nb/thunderbolt/thunderbolt.c: Init Alpine Ridge card ......................................................................
Patch Set 5:
(9 comments)
File src/drivers/51nb/thunderbolt/thunderbolt.c:
https://review.coreboot.org/c/coreboot/+/49672/comment/f92caf48_d4113f3f PS5, Line 20: while((pci_read_config16(dev,0x548) & 0x1) != 1 && count < 5000){ suspect code indent for conditional statements (0, 0)
https://review.coreboot.org/c/coreboot/+/49672/comment/c1f6e741_49732ca4 PS5, Line 20: while((pci_read_config16(dev,0x548) & 0x1) != 1 && count < 5000){ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/49672/comment/01728d9c_55b677e2 PS5, Line 20: while((pci_read_config16(dev,0x548) & 0x1) != 1 && count < 5000){ space required before the open brace '{'
https://review.coreboot.org/c/coreboot/+/49672/comment/78390241_d37d2cea PS5, Line 20: while((pci_read_config16(dev,0x548) & 0x1) != 1 && count < 5000){ space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/49672/comment/989b2d7c_0362fe15 PS5, Line 22: count ++; space prohibited before that '++' (ctx:WxO)
https://review.coreboot.org/c/coreboot/+/49672/comment/4107ea88_71995cc2 PS5, Line 24: if(count == 5000){ suspect code indent for conditional statements (0, 0)
https://review.coreboot.org/c/coreboot/+/49672/comment/97cbd664_5f8c12ab PS5, Line 24: if(count == 5000){ space required before the open brace '{'
https://review.coreboot.org/c/coreboot/+/49672/comment/6e40de81_ade40948 PS5, Line 24: if(count == 5000){ space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/49672/comment/857d19ff_af3e9138 PS5, Line 24: if(count == 5000){ braces {} are not necessary for single statement blocks